Skip to content

Add code coverage for multiple compilers with script schema#1515

Merged
shahzebsiddiqui merged 13 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch
Jul 10, 2023
Merged

Add code coverage for multiple compilers with script schema#1515
shahzebsiddiqui merged 13 commits intobuildtesters:develfrom
Mariamajib:Mariam_patch

Conversation

@Mariamajib
Copy link
Collaborator

@Mariamajib Mariamajib commented Jul 5, 2023 •
edited
Loading

  1. Created a symlink "stream_example.yml" to test the method process_compiler_config https://buildtest.readthedocs.io/en/devel/buildspecs/compiler.html#running-stream-benchmark-with-multiple-compilers
  2. Added method_process_compiler_config https://github.com/buildtesters/buildtest/blob/devel/tests/builders/test_builders.py
  3. Created a relative path to stream_examples.yml symlink

@braeeast2001
Copy link
Collaborator

braeeast2001 commented Jul 6, 2023

  1. @Mariamajib Please assign this PR to yourself
  2. Please retitle this PR to be a message about the general objective

@Mariamajib Mariamajib self-assigned this Jul 6, 2023
@Mariamajib Mariamajib changed the title created a symlink for python virtual environment Add code coverage for method _process_compiler_config #1444 Jul 6, 2023
@Mariamajib Mariamajib changed the title Add code coverage for method _process_compiler_config #1444 Add code coverage for method _process_compiler_config Jul 6, 2023
@Mendi03
Copy link
Collaborator

Mendi03 commented Jul 6, 2023

@Mariamajib Make sure to link your issue to this pull request.

@braeeast2001
Copy link
Collaborator

braeeast2001 commented Jul 6, 2023

  1. Please retitle your pull request to point towards the overall objective of your issue.
  2. @Mariamajib Please assign this to yourself

@Mariamajib Mariamajib assigned Mariamajib and unassigned Mariamajib Jul 6, 2023
@Mariamajib Mariamajib changed the title Add code coverage for method _process_compiler_config Add code coverage to process_compiler_config method Jul 6, 2023
@shahzebsiddiqui shahzebsiddiqui marked this pull request as ready for review July 7, 2023 14:24
@shahzebsiddiqui shahzebsiddiqui linked an issue Jul 7, 2023 that may be closed by this pull request
Add code coverage for method _process_compiler_config #1444
Closed
@shahzebsiddiqui shahzebsiddiqui changed the title Add code coverage to process_compiler_config method Add code coverage for multiple compilers with script schema Jul 7, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.51 🎉

Comparison is base (9e93d10) 77.02% compared to head (bf48aa1) 77.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1515      +/-   ##
==========================================
+ Coverage   77.02%   77.54%   +0.51%     
==========================================
  Files          57       57              
  Lines        6615     6615              
==========================================
+ Hits         5095     5129      +34     
+ Misses       1520     1486      -34
Impacted Files Coverage Δ
buildtest/utils/file.py 88.31% <0.00%> (ø)
buildtest/cli/build.py 95.93% <100.00%> (ø)
buildtest/cli/report.py 89.89% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui
Copy link
Member

shahzebsiddiqui commented Jul 8, 2023

@Mariamajib please remove the .swp file

shahzebsiddiqui
shahzebsiddiqui requested changes Jul 8, 2023
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the style check the yamllint check is failing. This package should be available if you did pip install -r docs/requirements.txt. If its set then just simply run yamllint buildtest tests at the root of directory and fix all the error messages. Ignore the warning. For more details see https://yamllint.readthedocs.io/en/stable/

@Mendi03
Copy link
Collaborator

Mendi03 commented Jul 10, 2023

The tests all ran to completion; however, something I noticed is that coverage was not added to the file specified in the original issue. Instead, Coverage was added to 3 different files as seen here

@shahzebsiddiqui What would be the next steps?

@Mariamajib
Copy link
Collaborator Author

Mariamajib commented Jul 10, 2023 •
edited
Loading

I discovered that the coverage was added to the file specified in the original issue base.py but it was under the indirect changes @shahzebsiddiqui @Mendi03 . Here is the link https://app.codecov.io/gh/buildtesters/buildtest/pull/1515/blob/buildtest/builders/base.py

@Mendi03
Copy link
Collaborator

Mendi03 commented Jul 10, 2023

I discovered that the coverage was added to the file specified in the original issue base.py but it was under the indirect changes @shahzebsiddiqui @Mendi03 . Here is the link https://app.codecov.io/gh/buildtesters/buildtest/pull/1515/blob/buildtest/builders/base.py

You're right! Let's wait and see what @shahzebsiddiqui has to say

@shahzebsiddiqui shahzebsiddiqui self-requested a review July 10, 2023 19:49
shahzebsiddiqui
shahzebsiddiqui approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mariamajib this looks good. Regression test is passing and i see code coverage is showing up.

Thanks and great work!. Congrats on your 1st contribution

@shahzebsiddiqui shahzebsiddiqui merged commit 58f91fd into buildtesters:devel Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzebsiddiqui shahzebsiddiqui shahzebsiddiqui approved these changes

@Mendi03 Mendi03 Awaiting requested review from Mendi03

@braeeast2001 braeeast2001 Awaiting requested review from braeeast2001

@kingxleyy kingxleyy Awaiting requested review from kingxleyy

Assignees

@Mariamajib Mariamajib

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add code coverage for method _process_compiler_config

4 participants

@Mariamajib @braeeast2001 @Mendi03 @shahzebsiddiqui