Add coverage to file_regex status check method#1511
Add coverage to file_regex status check method#1511shahzebsiddiqui merged 23 commits intobuildtesters:develfrom
Conversation
szuananwar
left a comment
There was a problem hiding this comment.
line 146: These is no file_regex.yml file in tutorials/test_status to link to, please make sure the name of yml file is correct.
Corrected file name
Corrected file name
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #1511 +/- ##
==========================================
+ Coverage 77.54% 77.97% +0.44%
==========================================
Files 57 57
Lines 6615 6615
==========================================
+ Hits 5129 5158 +29
+ Misses 1486 1457 -29 ☔ View full report in Codecov by Sentry. |
szuananwar
left a comment
There was a problem hiding this comment.
Please change the comment in 143 to match with the correct yml file name that will be linked for test.
Fixed comment in line 143
szuananwar
left a comment
There was a problem hiding this comment.
The comment in the methods matches the linked yml file.
|
@braeeast2001 for style check, please run buildtest sytle -a |
|
@shahzebsiddiqui I think @braeeast2001 first should check if the file is exists in the directory then do a regex check. I think she should use this test https://github.com/buildtesters/buildtest/blob/devel/tutorials/test_status/exists.yml for her regression test. What do you think? |
tests/builders/test_builders.py
Outdated
|
|
||
| def test_regex_check(): | ||
| """This test buildspec using status check with 'status_regex'""" | ||
| """This test buildspec using status check with 'status_regex'""" |
There was a problem hiding this comment.
change status_regex -> regex in doc string
Create new test for valid file_name with invalid regex and correct spelling mistake
…dtest into Brae'zah_Patch
szuananwar
left a comment
There was a problem hiding this comment.
Thanks @braeeast2001 for making all the necessary changes.
The style check is failed, please run buildtest sytle -a
and see this for more info: https://buildtest.readthedocs.io/en/devel/contributing/code_contribution_guide.html
and buildspec was invalid
| os.path.join(here, "regex_on_invalids.yml")], | ||
| buildspecs=[ | ||
| os.path.join(here, "regex_on_filename.yml"), | ||
| os.path.join(here, "regex_on_invalids.yml"), |
There was a problem hiding this comment.
Please delete the comma , before ]
Add test_file_regex to test_builders.py using regex_on_filename.yml.