adding regression test for modules#1503
Merged
shahzebsiddiqui merged 12 commits intobuildtesters:develfrom Jul 7, 2023
Merged
Conversation
shahzebsiddiqui
requested changes
Jun 29, 2023
Mendi03
requested changes
Jul 5, 2023
Collaborator
Mendi03
left a comment
There was a problem hiding this comment.
Check my comment on why the regression is failing. Furthermore, you still need to invoke the class with a value for module and unload_modules.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## devel #1503 +/- ##
==========================================
+ Coverage 76.46% 76.67% +0.21%
==========================================
Files 57 57
Lines 6614 6614
==========================================
+ Hits 5057 5071 +14
+ Misses 1557 1543 -14 ☔ View full report in Codecov by Sentry. |
Mendi03
reviewed
Jul 6, 2023
change invocation of "BuildTest" when invoking test and add comment on what is being tested
shahzebsiddiqui
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.