Added coverage to --retry#1501
Merged
shahzebsiddiqui merged 8 commits intobuildtesters:develfrom Jun 29, 2023
Merged
Conversation
Changed multiple files so that method test_retry would run properly.
Small commit to ignore .idea file from pycharm and reformatted some code to fit the style
removed .idea and added it to the .gitignore
Removed the following comment from the build.py file:
# if (timeout) or (limit is not None) or (retry is not None):
# list1 = [timeout, limit, retry]
# for x in list1:
# if not isinstance(x, int):
# raise BuildTestError(f"{x} is not of type int")
# if x <= 0:
# raise BuildTestError(f"{x} must be greater than 0")
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1501 +/- ##
==========================================
+ Coverage 76.20% 76.46% +0.25%
==========================================
Files 57 57
Lines 6619 6614 -5
==========================================
+ Hits 5044 5057 +13
+ Misses 1575 1557 -18
☔ View full report in Codecov by Sentry. |
Wrote a for loop under the _init__ method in buildtest class for better semantics
Changed https://github.com/marketplace/stale to https://github.com/marketplace/actions/close-stale-issues in the file docs/contributing/github_integration.rst
buildtest/cli/build.py
Outdated
| if not isinstance(field, int): | ||
| raise BuildTestError(f"{field} is not of type int") | ||
| if field <= 0: | ||
| raise BuildTestError("Limit must be greater than 0") |
Member
There was a problem hiding this comment.
change Limit -> {field}
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching that! Should be fixed now.
This was
linked to
issues
Jun 29, 2023
shahzebsiddiqui
approved these changes
Jun 29, 2023
Member
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
thanks @Mendi03 this looks good and congrats on your 1st contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did the following to add coverage for --retry:
I did not rewrite lines 563-583 under buildtest/cli/build.py since it caused errors with test_build_limit.
This is the code I tried using: