Merged
Conversation
…onschema to ensure each property type matches the input type used in BuildTest class. For 'buildspecs' property we resolve the full path before adding to configuration file since we will need this inorder to know where buildspec is.
… and override the class variables. Add method in SiteConfiguration class called 'get_profile' which will retrieve the profile given the name of profile specified by --profile. If profile doesn't exist or no profiles are created we raise and exception.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1489 +/- ##
==========================================
+ Coverage 75.50% 76.20% +0.70%
==========================================
Files 57 57
Lines 6568 6619 +51
==========================================
+ Hits 4959 5044 +85
+ Misses 1609 1575 -34
☔ View full report in Codecov by Sentry. |
…rofile since this is handled earlier in codebase when invoking SiteConfiguration class.
copy the config.yml from devel branch since we accidently updated the content of default configuration file which removed the comments
make minor changes to documentation
…o allow filter by tags, maintainers and type.
…e for '--executor-type'. Also check if --module-purge is passed then check if key is False if so we set to None so its not written in configuration file
update regression test to test for 'executor-type'. Also check when 'module-purge' is not passed as an option when saving profile configuration
6 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.