Skip to content

refactor codebase of 'buildtest inspect' #1466

Merged
shahzebsiddiqui merged 3 commits intodevelfrom
refactor_buildtest_inspect
May 5, 2023
Merged

refactor codebase of 'buildtest inspect' #1466
shahzebsiddiqui merged 3 commits intodevelfrom
refactor_buildtest_inspect

Conversation

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented May 5, 2023

No description provided.

@shahzebsiddiqui
refactor codebase of 'buildtest inspect' by removing method inspect_c…
03bb073 
…md and instead invoke the method directly. Refactor the regression tests

to avoid invoking inspect_cmd method
@shahzebsiddiqui
Copy link
Member Author

shahzebsiddiqui commented May 5, 2023

@Xiangs18 based on your last PR #1387 which turned out we needed to refactor some of the code-base. I did this basically removing the entry method inspect_cmd and invoke the method directly. This caused issues with regression tests as arguments had to be passed over to several methods such as inspect_cmd -> inspect_list just to invoke a certain test. This also avoids having us to define args.

@shahzebsiddiqui
move invocation of 'Report' class invocation in main.py inside the 'i…
8b1d3c4 
…nspect' if condition since this caused issues when report file was not present none of the commands would work
@shahzebsiddiqui
fix broken url for podman docs
5b28edb
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 ⚠️

Comparison is base (2220eeb) 75.08% compared to head (8b1d3c4) 74.95%.

❗ Current head 8b1d3c4 differs from pull request most recent head 5b28edb. Consider uploading reports for the commit 5b28edb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            devel    #1466      +/-   ##
==========================================
- Coverage   75.08%   74.95%   -0.13%     
==========================================
  Files          57       57              
  Lines        6537     6523      -14     
==========================================
- Hits         4908     4889      -19     
- Misses       1629     1634       +5
Impacted Files Coverage Δ
buildtest/cli/inspect.py 96.30% <100.00%> (-2.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui merged commit 5c50429 into devel May 5, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the refactor_buildtest_inspect branch May 5, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shahzebsiddiqui