Add pagination support for subcommands in "buildtest inspect" command#1428
Merged
shahzebsiddiqui merged 9 commits intodevelfrom Mar 22, 2023
Merged
Add pagination support for subcommands in "buildtest inspect" command#1428shahzebsiddiqui merged 9 commits intodevelfrom
shahzebsiddiqui merged 9 commits intodevelfrom
Conversation
7 tasks
shahzebsiddiqui
requested changes
Mar 22, 2023
Member
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
Overall this looks pretty good i made a few suggestions to the code-base. Please do check the code coverage to see if coverage results.
Collaborator
Author
@shahzebsiddiqui Yes, I have checked the code coverage it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @shahzebsiddiqui I have added pagination for buildtest inspect subcommands. I have also refactored the function
inspect_list()as the terse option in it was using hardcoded column names without a color option. Please review the PR.