Metrics support with arbitrary file#1422
Merged
shahzebsiddiqui merged 17 commits intodevelfrom Mar 14, 2023
Merged
Conversation
…d. The 'file' and 'stream' are mutually exclusive but one is required. Fix issue in metrics field where 'regex' was not mentioned as a required property which is needed in order to use metrics.
…' in regex and edge cases for metrics
update exmaple for metrics_regex.yml
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #1422 +/- ##
==========================================
+ Coverage 68.57% 75.15% +6.58%
==========================================
Files 57 57
Lines 6453 6464 +11
Branches 1158 0 -1158
==========================================
+ Hits 4425 4858 +433
+ Misses 2026 1606 -420
+ Partials 2 0 -2
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…a property within metrics as pose to having 'file' property inside 'regex'. The 'file_regex' in metrics will perform regular expression from file when assigning metrics.
…ng metrics with file_regex. Remove test that were not revelant according to JSON schema
…sonschema where 'file_regex' is a separate property.
…gex.yml add two example invalid metrics example update documentation with section on invalid metrics
…ng this to 'bash' executor for metrics example
…orrectly we can now enforce the pattern matching. update json schema and documentation
…ecified under 'regex' this is not an actual valid test for invalid examples since 'file' is no longer part of 'regex'
…le. This test will be used during regression test to add coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.