Skip to content

Metrics support with arbitrary file#1422

Merged
shahzebsiddiqui merged 17 commits intodevelfrom
metrics_file_regex
Mar 14, 2023
Merged

Metrics support with arbitrary file#1422
shahzebsiddiqui merged 17 commits intodevelfrom
metrics_file_regex

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

…d. The 'file' and 'stream' are mutually exclusive but one is required.

Fix issue in metrics field where 'regex' was not mentioned as a required property which is needed in order to use metrics.
update exmaple for metrics_regex.yml
@shahzebsiddiqui shahzebsiddiqui changed the title Declaring Metrics with support for file Metrics support with arbitrary file Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 74.58% and project coverage change: +6.58 🎉

Comparison is base (cde6a68) 68.57% compared to head (663d0e6) 75.15%.

❗ Current head 663d0e6 differs from pull request most recent head 1cdea0f. Consider uploading reports for the commit 1cdea0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1422      +/-   ##
==========================================
+ Coverage   68.57%   75.15%   +6.58%     
==========================================
  Files          57       57              
  Lines        6453     6464      +11     
  Branches     1158        0    -1158     
==========================================
+ Hits         4425     4858     +433     
+ Misses       2026     1606     -420     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
buildtest/cli/inspect.py 98.73% <ø> (+1.27%) ⬆️
buildtest/builders/base.py 78.53% <57.69%> (+24.05%) ⬆️
buildtest/cli/info.py 89.66% <70.00%> (+2.56%) ⬆️
buildtest/utils/file.py 88.31% <80.00%> (+0.81%) ⬆️
buildtest/buildsystem/checks.py 61.66% <100.00%> (+56.05%) ⬆️
buildtest/cli/__init__.py 91.69% <100.00%> (+0.03%) ⬆️
buildtest/cli/help.py 100.00% <100.00%> (+5.41%) ⬆️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…a property within metrics as pose to having

'file' property inside 'regex'. The 'file_regex' in metrics will perform regular expression from file when assigning metrics.
…ng metrics with file_regex. Remove test

that were not revelant according to JSON schema
…sonschema where 'file_regex'

is a separate property.
…gex.yml

add two example invalid metrics example
update documentation with section on invalid metrics
@shahzebsiddiqui shahzebsiddiqui linked an issue Mar 13, 2023 that may be closed by this pull request
@shahzebsiddiqui shahzebsiddiqui merged commit 869ab65 into devel Mar 14, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the metrics_file_regex branch March 14, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

capture metrics from arbitrary file names

1 participant