Skip to content

add yamllinter and shell linter check #1385

Merged
shahzebsiddiqui merged 21 commits intodevelfrom
superlinter
Feb 13, 2023
Merged

add yamllinter and shell linter check #1385
shahzebsiddiqui merged 21 commits intodevelfrom
superlinter

Conversation

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented Feb 10, 2023

No description provided.

@shahzebsiddiqui
move pyflakes ci check up a step so its run first.
77e14dc 
use black compatibility for 22.0
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 10, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 10, 2023
@shahzebsiddiqui shahzebsiddiqui mentioned this pull request Feb 10, 2023
Closed
@shahzebsiddiqui
Copy link
Member Author

shahzebsiddiqui commented Feb 13, 2023

@prathmesh4321 @Xiangs18 i will be adding this yamllint stylecheck to the stylecheck this will cause several files to start failing. I tried to fix several files but didnt do all of them. When you do get chance please do fix them in subsequent PRs.

@shahzebsiddiqui shahzebsiddiqui changed the title add superlinter check add yamllinter check Feb 13, 2023
@shahzebsiddiqui shahzebsiddiqui changed the title add yamllinter check add yamllinter and shell linter check Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023 •
edited
Loading

Codecov Report

Base: 69.16% // Head: 69.16% // No change to project coverage 👍

Coverage data is based on head (15f4b41) compared to base (cbc9a93).
Patch coverage: 2.78% of modified lines in pull request are covered.

❗ Current head 15f4b41 differs from pull request most recent head 08e8aa3. Consider uploading reports for the commit 08e8aa3 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##            devel    #1385   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files          57       57           
  Lines        6329     6329           
  Branches     1122     1122           
=======================================
  Hits         4377     4377           
  Misses       1950     1950           
  Partials        2        2
Impacted Files Coverage Δ
buildtest/builders/base.py 55.43% <0.00%> (ø)
buildtest/buildsystem/checks.py 5.77% <3.03%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui
remove shellcheck from pre-commit
65bfaec 
apply suggestions reported by shellcheck to several shell scripts
update .shellcheckrc file
@shahzebsiddiqui shahzebsiddiqui merged commit fd4cc42 into devel Feb 13, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the superlinter branch February 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shahzebsiddiqui