Skip to content

add support for limiting builds via 'buildtest build --limit'#1381

Merged
shahzebsiddiqui merged 7 commits intodevelfrom
buildtest_build_limit
Feb 13, 2023
Merged

add support for limiting builds via 'buildtest build --limit'#1381
shahzebsiddiqui merged 7 commits intodevelfrom
buildtest_build_limit

Conversation

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented Feb 9, 2023 •
edited
Loading

without limit

(buildtest)  ~/Documents/github/buildtest/ [buildtest_build_limit*] buildtest bd -t python          
╭───────────────────────────────────── buildtest summary ──────────────────────────────────────╮                                                                                                                                           
│                                                                                              │                                                                                                                                           
│ User:               siddiq90                                                                 │                                                                                                                                           
│ Hostname:           DOE-7086392                                                              │                                                                                                                                           
│ Platform:           Darwin                                                                   │                                                                                                                                           
│ Current Time:       2023/02/09 14:06:15                                                      │                                                                                                                                           
│ buildtest path:     /Users/siddiq90/Documents/github/buildtest/bin/buildtest                 │                                                                                                                                           
│ buildtest version:  1.2                                                                      │                                                                                                                                           
│ python path:        /Users/siddiq90/.local/share/virtualenvs/buildtest-Ir4AdrfC/bin/python3  │                                                                                                                                           
│ python version:     3.7.3                                                                    │                                                                                                                                           
│ Configuration File: /Users/siddiq90/Documents/github/buildtest/buildtest/settings/config.yml │                                                                                                                                           
│ Test Directory:     /Users/siddiq90/Documents/github/buildtest/var/tests                     │                                                                                                                                           
│ Report File:        /Users/siddiq90/Documents/github/buildtest/var/report.json               │                                                                                                                                           
│ Command:            /Users/siddiq90/Documents/github/buildtest/bin/buildtest bd -t python    │                                                                                                                                           
│                                                                                              │                                                                                                                                           
╰──────────────────────────────────────────────────────────────────────────────────────────────╯                                                                                                                                           
─────────────────────────────────────────────────────────────────────────────────────────────────────────  Discovering Buildspecs ─────────────────────────────────────────────────────────────────────────────────────────────────────────
                          Discovered buildspecs                          
╔═══════════════════════════════════════════════════════════════════════╗
║ buildspec                                                             ║
╟───────────────────────────────────────────────────────────────────────╢
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml ║
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml ║
╚═══════════════════════════════════════════════════════════════════════╝
                        Buildspecs By Tag=python                         
╔═══════════════════════════════════════════════════════════════════════╗
║ buildspec                                                             ║
╟───────────────────────────────────────────────────────────────────────╢
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml ║
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml ║
╚═══════════════════════════════════════════════════════════════════════╝


Total Discovered Buildspecs:  2
Total Excluded Buildspecs:  0
Detected Buildspecs after exclusion:  2
─────────────────────────────────────────────────────────────────────────────────────────────────────────── Parsing Buildspecs ────────────────────────────────────────────────────────────────────────────────────────────────────────────
Valid Buildspecs: 2
Invalid Buildspecs: 0
/Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml: VALID
/Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml: VALID
Total builder objects created: 2
                                                                                      Builders by type=script                                                                                       
┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ builder               ┃ type   ┃ executor           ┃ compiler ┃ nodes ┃ procs ┃ description                             ┃ buildspecs                                                            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ circle_area/3277599a  │ script │ generic.local.bash │ None     │ None  │ None  │ Calculate circle of area given a radius │ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml │
├───────────────────────┼────────┼────────────────────┼──────────┼───────┼───────┼─────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────┤
│ python_hello/678e14ec │ script │ generic.local.bash │ None     │ None  │ None  │ Hello World python                      │ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml │
└───────────────────────┴────────┴────────────────────┴──────────┴───────┴───────┴─────────────────────────────────────────┴───────────────────────────────────────────────────────────────────────┘
────────────────────────────────────────────────────────────────────────────────────────────────────────────── Building Test ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
circle_area/3277599a: Creating test directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a
circle_area/3277599a: Creating the stage directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a/stage
circle_area/3277599a: Writing build script: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a/circle_area_build.sh
python_hello/678e14ec: Creating test directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec
python_hello/678e14ec: Creating the stage directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec/stage
python_hello/678e14ec: Writing build script: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec/python_hello_build.sh
────────────────────────────────────────────────────────────────────────────────────────────────────────────── Running Tests ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
Spawning 1 processes for processing builders
─────────────────────────────────────────────────────────────────────────────────────────────────────────────── Iteration 1 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────
circle_area/3277599a does not have any dependencies adding test to queue
python_hello/678e14ec does not have any dependencies adding test to queue
In this iteration we are going to run the following tests: [circle_area/3277599a, python_hello/678e14ec]
circle_area/3277599a: Current Working Directory : /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a/stage
circle_area/3277599a: Running Test via command: bash --norc --noprofile -eo pipefail circle_area_build.sh
circle_area/3277599a: Test completed in 0.140125 seconds
circle_area/3277599a: Test completed with returncode: 0
circle_area/3277599a: Writing output file -  /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a/circle_area.out
circle_area/3277599a: Writing error file - /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/3277599a/circle_area.err
python_hello/678e14ec: Current Working Directory : /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec/stage
python_hello/678e14ec: Running Test via command: bash --norc --noprofile -eo pipefail python_hello_build.sh
python_hello/678e14ec: Test completed in 0.122984 seconds
python_hello/678e14ec: Test completed with returncode: 0
python_hello/678e14ec: Writing output file -  /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec/python_hello.out
python_hello/678e14ec: Writing error file - /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-hello/python_hello/678e14ec/python_hello.err
                                                    Test Summary                                                     
┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ builder               ┃ executor           ┃ status ┃ checks (ReturnCode, Regex, Runtime) ┃ returncode ┃ runtime  ┃
┡━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━┩
│ circle_area/3277599a  │ generic.local.bash │ PASS   │ N/A N/A N/A                         │ 0          │ 0.140125 │
├───────────────────────┼────────────────────┼────────┼─────────────────────────────────────┼────────────┼──────────┤
│ python_hello/678e14ec │ generic.local.bash │ PASS   │ N/A N/A N/A                         │ 0          │ 0.122984 │
└───────────────────────┴────────────────────┴────────┴─────────────────────────────────────┴────────────┴──────────┘



Passed Tests: 2/2 Percentage: 100.000%
Failed Tests: 0/2 Percentage: 0.000%


Adding 2 test results to /Users/siddiq90/Documents/github/buildtest/var/report.json
Writing Logfile to: /Users/siddiq90/Documents/github/buildtest/var/logs/buildtest_x1ltfop9.log

with limit

(buildtest)  ~/Documents/github/buildtest/ [buildtest_build_limit*] buildtest bd -t python --limit=1
╭───────────────────────────────────────── buildtest summary ─────────────────────────────────────────╮                                                                                                                                    
│                                                                                                     │                                                                                                                                    
│ User:               siddiq90                                                                        │                                                                                                                                    
│ Hostname:           DOE-7086392                                                                     │                                                                                                                                    
│ Platform:           Darwin                                                                          │                                                                                                                                    
│ Current Time:       2023/02/09 14:06:04                                                             │                                                                                                                                    
│ buildtest path:     /Users/siddiq90/Documents/github/buildtest/bin/buildtest                        │                                                                                                                                    
│ buildtest version:  1.2                                                                             │                                                                                                                                    
│ python path:        /Users/siddiq90/.local/share/virtualenvs/buildtest-Ir4AdrfC/bin/python3         │                                                                                                                                    
│ python version:     3.7.3                                                                           │                                                                                                                                    
│ Configuration File: /Users/siddiq90/Documents/github/buildtest/buildtest/settings/config.yml        │                                                                                                                                    
│ Test Directory:     /Users/siddiq90/Documents/github/buildtest/var/tests                            │                                                                                                                                    
│ Report File:        /Users/siddiq90/Documents/github/buildtest/var/report.json                      │                                                                                                                                    
│ Command:            /Users/siddiq90/Documents/github/buildtest/bin/buildtest bd -t python --limit=1 │                                                                                                                                    
│                                                                                                     │                                                                                                                                    
╰─────────────────────────────────────────────────────────────────────────────────────────────────────╯                                                                                                                                    
─────────────────────────────────────────────────────────────────────────────────────────────────────────  Discovering Buildspecs ─────────────────────────────────────────────────────────────────────────────────────────────────────────
                          Discovered buildspecs                          
╔═══════════════════════════════════════════════════════════════════════╗
║ buildspec                                                             ║
╟───────────────────────────────────────────────────────────────────────╢
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml ║
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml ║
╚═══════════════════════════════════════════════════════════════════════╝
                        Buildspecs By Tag=python                         
╔═══════════════════════════════════════════════════════════════════════╗
║ buildspec                                                             ║
╟───────────────────────────────────────────────────────────────────────╢
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml ║
║ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml ║
╚═══════════════════════════════════════════════════════════════════════╝


Total Discovered Buildspecs:  2
Total Excluded Buildspecs:  0
Detected Buildspecs after exclusion:  2
─────────────────────────────────────────────────────────────────────────────────────────────────────────── Parsing Buildspecs ────────────────────────────────────────────────────────────────────────────────────────────────────────────
Valid Buildspecs: 2
Invalid Buildspecs: 0
/Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml: VALID
/Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml: VALID
Total builder objects created: 2
                                                                                      Builders by type=script                                                                                       
┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━┳━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ builder               ┃ type   ┃ executor           ┃ compiler ┃ nodes ┃ procs ┃ description                             ┃ buildspecs                                                            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━╇━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ circle_area/8fbf0081  │ script │ generic.local.bash │ None     │ None  │ None  │ Calculate circle of area given a radius │ /Users/siddiq90/Documents/github/buildtest/tutorials/python-shell.yml │
├───────────────────────┼────────┼────────────────────┼──────────┼───────┼───────┼─────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────┤
│ python_hello/6b29e933 │ script │ generic.local.bash │ None     │ None  │ None  │ Hello World python                      │ /Users/siddiq90/Documents/github/buildtest/tutorials/python-hello.yml │
└───────────────────────┴────────┴────────────────────┴──────────┴───────┴───────┴─────────────────────────────────────────┴───────────────────────────────────────────────────────────────────────┘
Limit number of tests to 1 for Building and Running. 
────────────────────────────────────────────────────────────────────────────────────────────────────────────── Building Test ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
circle_area/8fbf0081: Creating test directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081
circle_area/8fbf0081: Creating the stage directory: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081/stage
circle_area/8fbf0081: Writing build script: /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081/circle_area_build.sh
────────────────────────────────────────────────────────────────────────────────────────────────────────────── Running Tests ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
Spawning 1 processes for processing builders
─────────────────────────────────────────────────────────────────────────────────────────────────────────────── Iteration 1 ───────────────────────────────────────────────────────────────────────────────────────────────────────────────
circle_area/8fbf0081 does not have any dependencies adding test to queue
In this iteration we are going to run the following tests: [circle_area/8fbf0081]
circle_area/8fbf0081: Current Working Directory : /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081/stage
circle_area/8fbf0081: Running Test via command: bash --norc --noprofile -eo pipefail circle_area_build.sh
circle_area/8fbf0081: Test completed in 0.14818 seconds
circle_area/8fbf0081: Test completed with returncode: 0
circle_area/8fbf0081: Writing output file -  /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081/circle_area.out
circle_area/8fbf0081: Writing error file - /Users/siddiq90/Documents/github/buildtest/var/tests/generic.local.bash/python-shell/circle_area/8fbf0081/circle_area.err
                                                   Test Summary                                                    
┏━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━┓
┃ builder              ┃ executor           ┃ status ┃ checks (ReturnCode, Regex, Runtime) ┃ returncode ┃ runtime ┃
┡━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━┩
│ circle_area/8fbf0081 │ generic.local.bash │ PASS   │ N/A N/A N/A                         │ 0          │ 0.14818 │
└──────────────────────┴────────────────────┴────────┴─────────────────────────────────────┴────────────┴─────────┘



Passed Tests: 1/1 Percentage: 100.000%
Failed Tests: 0/1 Percentage: 0.000%


Adding 1 test results to /Users/siddiq90/Documents/github/buildtest/var/report.json
Writing Logfile to: /Users/siddiq90/Documents/github/buildtest/var/logs/buildtest_tsl1697a.log

@shahzebsiddiqui
add option 'buildtest build --limit'
52295c1 
add support for limiting number of tests based on value of --limit
add option to bash completion
@shahzebsiddiqui
add regression test coverage for limit option
d9fe957
@shahzebsiddiqui shahzebsiddiqui self-assigned this Feb 9, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 9, 2023
@shahzebsiddiqui
Copy link
Member Author

shahzebsiddiqui commented Feb 9, 2023

@prathmesh4321 @Xiangs18 hey i am implementing a new feature for buildtest build to limit number of tests, can you take a look at this feature and review this.

@shahzebsiddiqui shahzebsiddiqui linked an issue Feb 9, 2023 that may be closed by this pull request
[FEATURE]: Limit number of test that can be run with buildtest build #1380
Closed
2 tasks
@shahzebsiddiqui
Copy link
Member Author

shahzebsiddiqui commented Feb 10, 2023

@Xiangs18 i asked black in psf/black#3562 regarding the CI check failure. I locally updated black once #1370 was merged it and it turns out the new version of black was the issue.

prathmesh4321
prathmesh4321 requested changes Feb 13, 2023
View reviewed changes
@shahzebsiddiqui shahzebsiddiqui merged commit 4c4b42b into devel Feb 13, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the buildtest_build_limit branch February 13, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prathmesh4321 prathmesh4321 prathmesh4321 requested changes

@Xiangs18 Xiangs18 Awaiting requested review from Xiangs18

Assignees

@shahzebsiddiqui shahzebsiddiqui

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Limit number of test that can be run with buildtest build

2 participants

@shahzebsiddiqui @prathmesh4321