Assert greater than status check#1354
Merged
shahzebsiddiqui merged 4 commits intodevelfrom Jan 25, 2023
Merged
Conversation
Closed
Codecov ReportBase: 71.03% // Head: 70.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1354 +/- ##
==========================================
- Coverage 71.03% 70.68% -0.35%
==========================================
Files 57 57
Lines 6131 6163 +32
Branches 1090 1096 +6
==========================================
+ Hits 4355 4356 +1
- Misses 1774 1805 +31
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shahzebsiddiqui
approved these changes
Jan 25, 2023
Member
shahzebsiddiqui
left a comment
There was a problem hiding this comment.
great job @prathmesh4321 this looks excellent. I don't see any issues with this so merging this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @shahzebsiddiqui I have added assert greater than status check. Please review the PR.