Skip to content

change executor match from equality check to regex (re.fullmatch) #1350

Merged
shahzebsiddiqui merged 1 commit intodevelfrom
change_executor_match
Jan 24, 2023
Merged

change executor match from equality check to regex (re.fullmatch) #1350
shahzebsiddiqui merged 1 commit intodevelfrom
change_executor_match

Conversation

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui shahzebsiddiqui commented Jan 24, 2023 •
edited
Loading

There was an issue with validating test when executor property was using a regex. Current behavior was equality check with the executors defined in configuration file. This caused tests like https://github.com/buildtesters/buildtest-nersc/blob/devel/buildspecs/apps/hpctoolkit/hpctoolkit_cuda_vecadd_pc_perlmutter.yml to fail where we had the following for executor - executor: '(perlmutter|muller).slurm.regular'

With this change i was able to confirm validation and tags was picking up executors.

(buildtest)  ~/gitrepos/buildtest-nersc/ [devel] buildtest bc find --filter buildspec=/global/u1/s/siddiq90/gitrepos/buildtest-nersc/buildspecs/apps/hpctoolkit/hpctoolkit_cuda_vecadd_perlmutter.yml
          Buildspec Cache: /global/u1/s/siddiq90/gitrepos/buildtest/var/buildspecs/cache.json
 name            ┃ type   ┃ executor                          ┃ tags ┃ description
━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 hpctoolkit_cuda │ script │ (perlmutter|muller).slurm.regular │ e4s  │ HPCToolkit vector add CUDA test

@wyphan with this change i expect hpctoolkit test will run now that we change executor check to re.fullmatch

@shahzebsiddiqui
change executor match from equality to re.fullmatch to ensure test is…
3ed0c27 
… valid when used with regular expression otherwise the equality match doesnt work

with string comparison
@shahzebsiddiqui shahzebsiddiqui self-assigned this Jan 24, 2023
@shahzebsiddiqui shahzebsiddiqui merged commit 416ee56 into devel Jan 24, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the change_executor_match branch January 24, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@shahzebsiddiqui shahzebsiddiqui

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shahzebsiddiqui