Assert less than and equal status check#1339
Merged
shahzebsiddiqui merged 12 commits intodevelfrom Jan 13, 2023
Merged
Conversation
4 tasks
Codecov ReportBase: 71.41% // Head: 71.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1339 +/- ##
==========================================
- Coverage 71.41% 71.05% -0.36%
==========================================
Files 57 57
Lines 6093 6125 +32
Branches 1081 1087 +6
==========================================
+ Hits 4351 4352 +1
- Misses 1740 1771 +31
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Comment on lines
+1
to
+46
| buildspecs: | ||
| assert_le_example: | ||
| type: script | ||
| executor: generic.local.bash | ||
| description: Run stream test with metrics example using assert less than equal | ||
| env: | ||
| OMP_NUM_THREADS: 4 | ||
| run: | | ||
| wget https://raw.githubusercontent.com/jeffhammond/STREAM/master/stream.c | ||
| gcc -openmp -o stream stream.c | ||
| ./stream | ||
| metrics: | ||
| copy: | ||
| type: float | ||
| regex: | ||
| exp: 'Copy:\s+(\S+)\s+.*' | ||
| stream: stdout | ||
| item: 1 | ||
| scale: | ||
| type: float | ||
| regex: | ||
| exp: 'Scale:\s+(\S+)\s+.*' | ||
| stream: stdout | ||
| item: 1 | ||
| add: | ||
| type: float | ||
| regex: | ||
| exp: 'Add:\s+(\S+)\s+.*' | ||
| stream: stdout | ||
| item: 1 | ||
| triad: | ||
| type: float | ||
| regex: | ||
| exp: 'Triad:\s+(\S+)\s+.*' | ||
| stream: stdout | ||
| item: 1 | ||
| status: | ||
| assert_le: | ||
| - name: copy | ||
| ref: 5000 | ||
| - name: scale | ||
| ref: 5500 | ||
| - name: add | ||
| ref: 6000 | ||
| - name: triad | ||
| ref: 6500 No newline at end of file |
Member
There was a problem hiding this comment.
i think for now let's keep these files but i think we may want to merge this one test into one single test such that we can have all the checks in one test
Member
|
@Xiangs18 thanks this PR looks good. I will merge this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @shahzebsiddiqui, please take a look at MR and provide feedback. Thank you!