Skip to content

Add support for Assert Equality #1320

Merged
shahzebsiddiqui merged 7 commits intodevelfrom
assert_eq
Dec 21, 2022
Merged

Add support for Assert Equality #1320
shahzebsiddiqui merged 7 commits intodevelfrom
assert_eq

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

Example buildspec that includes 'assert_eq' in status check
update definitions.schema.json with support for this property.
refactor codebase by reusing redundant code in separate methods
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 72.64% // Head: 72.12% // Decreases project coverage by -0.52% ⚠️

Coverage data is based on head (b368190) compared to base (904b8f5).
Patch coverage: 4.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1320      +/-   ##
==========================================
- Coverage   72.64%   72.12%   -0.52%     
==========================================
  Files          56       56              
  Lines        5972     6018      +46     
  Branches     1058     1041      -17     
==========================================
+ Hits         4338     4340       +2     
- Misses       1632     1678      +46     
+ Partials        2        0       -2     
Impacted Files Coverage Δ
buildtest/executors/base.py 87.88% <ø> (ø)
buildtest/builders/base.py 47.56% <4.62%> (-3.59%) ⬇️
buildtest/executors/setup.py 72.82% <0.00%> (-0.13%) ⬇️
buildtest/tools/stylecheck.py 89.83% <0.00%> (ø)
buildtest/executors/cobalt.py 22.34% <0.00%> (+0.24%) ⬆️
buildtest/config.py 50.00% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

add exception test for assert_ge
update regression test to ensure we test assert_eq.
add buildspec assert_eq_exceptions.yml
make 'type' a required pro[erty in the metrics property
…iling. The issue was with validating

test using 'metrics' property
@shahzebsiddiqui shahzebsiddiqui merged commit 138c2b5 into devel Dec 21, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the assert_eq branch December 21, 2022 21:07
@shahzebsiddiqui shahzebsiddiqui mentioned this pull request Dec 21, 2022
@shahzebsiddiqui shahzebsiddiqui linked an issue Dec 21, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert Equal

1 participant