Skip to content

Update logic for Buildspec Parser to incorporate executor check#1309

Merged
shahzebsiddiqui merged 7 commits intodevelfrom
executor_check_in_parser
Dec 13, 2022
Merged

Update logic for Buildspec Parser to incorporate executor check#1309
shahzebsiddiqui merged 7 commits intodevelfrom
executor_check_in_parser

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

… raises exception

when 'executor' property doesn't match a valid executor name
add exception types InvalidBuildspec, InvalidBuildspecSchemaType, InvalidBuildspecExecutor that are used to
raise exceptions when parsing buildspec

The BuildspecError exception now accepts optional argument for 'buildspec' argument

update the codebase to catch the appropriate exception during 'buildtest build', 'buildtest buildspec validate', 'buildtest buildspec find'
…variables to be explicit what arguments are passed to which variable
…or exception handling when this

class is called. In BuildTest, where we invocate BuildspecParser we call method without checking for
executor hence, InvalidBuildspecExecutor won't be raised
… 'test_BuildspecParser_exceptions' will

check for all exceptions and the other method 'test_BuildspecParser' will test the class logic.
Change behavior of 'walk_tree' method to return absolute path to all files
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 73.21% // Head: 73.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dcdb0ba) compared to base (3b18650).
Patch coverage: 87.72% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1309   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files          55       56    +1     
  Lines        5886     5924   +38     
  Branches      997     1051   +54     
=======================================
+ Hits         4309     4337   +28     
- Misses       1577     1585    +8     
- Partials        0        2    +2     
Impacted Files Coverage Δ
buildtest/exceptions.py 53.85% <20.00%> (-5.24%) ⬇️
buildtest/cli/buildspec.py 94.86% <88.00%> (+0.01%) ⬆️
buildtest/buildsystem/parser.py 100.00% <100.00%> (+9.80%) ⬆️
buildtest/cli/build.py 92.28% <100.00%> (ø)
buildtest/utils/file.py 86.81% <100.00%> (ø)
buildtest/config.py 50.00% <0.00%> (ø)
buildtest/tools/tutorialexamples.py 52.00% <0.00%> (ø)
buildtest/cli/__init__.py 91.67% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shahzebsiddiqui shahzebsiddiqui merged commit 9b5be39 into devel Dec 13, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the executor_check_in_parser branch December 13, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant