Update logic for Buildspec Parser to incorporate executor check#1309
Merged
shahzebsiddiqui merged 7 commits intodevelfrom Dec 13, 2022
Merged
Update logic for Buildspec Parser to incorporate executor check#1309shahzebsiddiqui merged 7 commits intodevelfrom
shahzebsiddiqui merged 7 commits intodevelfrom
Conversation
… raises exception when 'executor' property doesn't match a valid executor name
add exception types InvalidBuildspec, InvalidBuildspecSchemaType, InvalidBuildspecExecutor that are used to raise exceptions when parsing buildspec The BuildspecError exception now accepts optional argument for 'buildspec' argument update the codebase to catch the appropriate exception during 'buildtest build', 'buildtest buildspec validate', 'buildtest buildspec find'
…variables to be explicit what arguments are passed to which variable
…or exception handling when this class is called. In BuildTest, where we invocate BuildspecParser we call method without checking for executor hence, InvalidBuildspecExecutor won't be raised
… 'test_BuildspecParser_exceptions' will check for all exceptions and the other method 'test_BuildspecParser' will test the class logic. Change behavior of 'walk_tree' method to return absolute path to all files
…cExecutor not ValidationError
Codecov ReportBase: 73.21% // Head: 73.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1309 +/- ##
=======================================
Coverage 73.21% 73.21%
=======================================
Files 55 56 +1
Lines 5886 5924 +38
Branches 997 1051 +54
=======================================
+ Hits 4309 4337 +28
- Misses 1577 1585 +8
- Partials 0 2 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.