Skip to content

document how to generate examples for buildtest tutorial#1289

Merged
shahzebsiddiqui merged 4 commits intodevelfrom
docs_on_autogenerated_examples
Nov 3, 2022
Merged

document how to generate examples for buildtest tutorial#1289
shahzebsiddiqui merged 4 commits intodevelfrom
docs_on_autogenerated_examples

Conversation

@shahzebsiddiqui
Copy link
Member

No description provided.

@shahzebsiddiqui shahzebsiddiqui added the documentation documentation fix label Oct 28, 2022
@shahzebsiddiqui shahzebsiddiqui self-assigned this Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 78.73% // Head: 81.77% // Increases project coverage by +3.04% 🎉

Coverage data is based on head (a3ab9ae) compared to base (dc12707).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1289      +/-   ##
==========================================
+ Coverage   78.73%   81.77%   +3.04%     
==========================================
  Files          55       55              
  Lines        5892     5892              
  Branches     1040     1040              
==========================================
+ Hits         4639     4818     +179     
+ Misses       1253     1074     -179     
Impacted Files Coverage Δ
buildtest/executors/setup.py 90.82% <0.00%> (+1.93%) ⬆️
buildtest/builders/base.py 69.96% <0.00%> (+5.81%) ⬆️
buildtest/scheduler/job.py 85.71% <0.00%> (+7.14%) ⬆️
buildtest/system.py 78.79% <0.00%> (+8.08%) ⬆️
buildtest/cli/compilers.py 82.76% <0.00%> (+9.85%) ⬆️
buildtest/config.py 64.50% <0.00%> (+10.00%) ⬆️
buildtest/executors/lsf.py 60.00% <0.00%> (+40.00%) ⬆️
buildtest/scheduler/lsf.py 97.30% <0.00%> (+72.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@prathmesh4321 prathmesh4321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzebsiddiqui I think it should be source scripts/spack_container/setup.sh https://github.com/buildtesters/buildtest/pull/1289/files#:~:text=source%20scripts/spack_container/setup.py

Also the command is not able to create a virtual env when I run it inside the container. I t gives the following error:
image

@shahzebsiddiqui
Copy link
Member Author

@shahzebsiddiqui I think it should be source scripts/spack_container/setup.sh https://github.com/buildtesters/buildtest/pull/1289/files#:~:text=source%20scripts/spack_container/setup.py

Also the command is not able to create a virtual env when I run it inside the container. I t gives the following error: image

good catch i had a typo i changed setup.py -> setup.sh in my latest commit.

Also regarding the screenshot it looks like it failed on the module command i wonder if you can try docker run -it -v $BUILDTEST_ROOT:/home/spack/buildtest ghcr.io/buildtesters/buildtest_spack:latest /bin/bash and see if that creates an interactive shell. What you should expect is the following

(buildtest)  ~/Documents/github/buildtest/ [docs_on_autogenerated_examples] docker run -it -v  $BUILDTEST_ROOT:/home/spack/buildtest ghcr.io/buildtesters/buildtest_spack:latest
==> Regenerating tcl module files
spack@5c7f013efe70:~$ ls -ld /home/spack/buildtest/
drwxr-xr-x 41 root root 1312 Oct 28 19:12 /home/spack/buildtest/
spack@5c7f013efe70:~$ module list
No modules loaded
spack@5c7f013efe70:~$ cd /home/spack/buildtest/
spack@5c7f013efe70:~/buildtest$ source scripts/spack_container/setup.sh 
(buildtest) spack@5c7f013efe70:~/buildtest$ module list

Currently Loaded Modules:
  1) python/3.8.6-gcc-7.5.0

 

(buildtest) spack@5c7f013efe70:~/buildtest$ which python
/home/spack/pyenv/buildtest/bin/python
(buildtest) spack@5c7f013efe70:~/buildtest$ python --version
Python 3.8.6
(buildtest) spack@5c7f013efe70:~/buildtest$ which buildtest
/home/spack/buildtest/bin/buildtest
(buildtest) spack@5c7f013efe70:~/buildtest$ buildtest cg p
/home/spack/buildtest/buildtest/settings/spack_container.yml

@prathmesh4321
Copy link
Collaborator

The examples are getting generated but need to do "source /etc/profile" as we discussed after the docker run command.

image

@shahzebsiddiqui
Copy link
Member Author

The examples are getting generated but need to do "source /etc/profile" as we discussed after the docker run command.

image

thanks for confirming. Ill put a note about source /etc/profile

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 3, 2022
@shahzebsiddiqui shahzebsiddiqui merged commit b364cc6 into devel Nov 3, 2022
@shahzebsiddiqui shahzebsiddiqui deleted the docs_on_autogenerated_examples branch November 3, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation documentation fix size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants