Adding --label flag to pack builder create command#2034
Merged
jjbustamante merged 1 commit intomainfrom Jan 26, 2024
Merged
Conversation
fd8c921 to
ff33cae
Compare
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
ff33cae to
bdc66d2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
==========================================
+ Coverage 79.63% 79.63% +0.01%
==========================================
Files 176 176
Lines 13199 13214 +15
==========================================
+ Hits 10510 10522 +12
- Misses 2020 2022 +2
- Partials 669 670 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
@matejvasek could you take a look at the binaries @natalieparellano could you give me a review here? |
Contributor
|
@jjbustamante I do not use this as a binary but rather as a library. Regardless this PR seems to work for me. |
natalieparellano
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
--labelflag to thepack builder createcommandOutput
Before
The flag didn't exist before
After
New flag will look like this, when running
pack builder create --helpRunning a local builder creation like
output
{ "foo": "bar", "io.buildpacks.base.distro.name": "ubuntu", "io.buildpacks.base.distro.version": "\"22.04\"", "io.buildpacks.builder.metadata": "...." }As we can see the label "foo=bar" was set to the builder image
Documentation
Related
Resolves #2033