Skip to content

feat: use detached spawn for agent #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgammon merged 43 commits into from
Dec 4, 2023
Merged

feat: use detached spawn for agent #5

sgammon merged 43 commits into from
Dec 4, 2023

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Dec 1, 2023

Summary

Adds functionality to detect and use an existing agent, if available. Adds several unit tests, and shifts to spawning the agent via a detached child process rather than calling buildless agent start.

Changelog

  • feat: detect and use existing agent ("unmanaged" mode)
  • fix: prepare temp paths before installation
  • test: significant improvement in test coverage

@sgammon
feat: use existing agent if available
e48a5d6 
- feat: detect and use existing agent ("unmanaged" mode)
- fix: prepare temp paths before installation
- test: significant improvement in test coverage

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon added the enhancement New feature or request label Dec 1, 2023
@sgammon sgammon self-assigned this Dec 1, 2023
@sgammon
fix: longer test timeout for installation
c4776bd 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: tool cache defaults, general option logic fixes
2ba5f87 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: run formatter
9f4e507 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebundle
ed99c03 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
test: many fixes, much testing
edb0585 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon force-pushed the feat/existing-agent branch 10 times, most recently from 5b6fa90 to b603405 Compare December 1, 2023 23:09
@sgammon
test: additional test fixes and enhancements for agent
a365acd 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon force-pushed the feat/existing-agent branch from b603405 to a365acd Compare December 1, 2023 23:11
@sgammon
chore: cleanup ci jobs, add actionlint check
c13cd1b 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@codecov
Copy link

codecov bot commented Dec 2, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@sgammon
chore(ci): cleanup/combine linter actions
40a30fc 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore(ci): further workflow cleanup and fixes
bb61fb1 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@github-advanced-security
Copy link

github-advanced-security bot commented Dec 2, 2023

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sgammon
fix(ci): reference to check-dist job
a24efab 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix(cli): permissions for action linter
d2c28f9 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix(lint): fixes for actionlint-reported issues
e5a723b 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
test: linter fixes, smoke tests, sonar fix
2004b87 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix(ci): useless cat flagged by actionlint shellcheck
d8a7b2f 
Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon added 27 commits December 3, 2023 20:55
@sgammon
fix: next round of launch fixes for agent
6d2fd46 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: various fixes for new logic
1f0c5e3 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebundle
06ba21a 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: add http-client/cache dependencies
6c28a5c 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
feat(cli): current job context as json
dfc7dc4 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
feat(cli): use new cli api to resolve version
6e2ef16 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: update pnpm lock
f3146f9 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebundle
5903585 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: refactor to remove context options
7b1db29 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebundle
440a584 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: cleanup pr jobs into one workflow
729d87f 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: generate uuid for service instance id on linux
cc88fd1 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: permissions for codeql nested workflow
dcbe633 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: readme updates, rebundle
dae6c64 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: drop caching of agent config
daf8c74 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: add husky/commitlint
3b5fcf7 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: require DCO via commitlint
c08ad98 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: husky commit msg needs to be executable
0bbf61d 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: dual linting via actionlint
25936f8 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: markdown/code of conduct issues
cc15da1 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: codestyle in commitlint
c668693 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore(ci): test matrix improvements
ddc17c9 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix(ci): matrix changes
2166eba 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: enable macos x86
6242188 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: rebuild bundle
c66686d 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
fix: drop x86 mac until fixed upstream
bdeee21 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
chore: cleanup before 1.0.1 release
85bb817 
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon marked this pull request as ready for review December 4, 2023 07:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2023 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

32.9% 32.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sgammon sgammon merged commit 678e022 into main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sgammon sgammon

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgammon