Prevent OOM with bounded thread pool and memory cleanup#250
Merged
Conversation
1ba7331 to
eaebf52
Compare
joshuay03
commented
Feb 8, 2026
| spec.add_dependency "concurrent-ruby" | ||
|
|
||
| spec.add_development_dependency "activesupport", ">= 4.2" | ||
| spec.add_development_dependency "ostruct" |
Contributor
Author
There was a problem hiding this comment.
This is needed for Ruby >= 4.0. Ideally we'd make it conditional, but the main issue is that we check-in Gemfile.lock in this repo, which isn't ideal when supporting multiple Ruby versions, so leaving like this for now.
Member
There was a problem hiding this comment.
Should we remove Gemfile.lock from git do you think?
pda
approved these changes
Feb 10, 2026
Member
pda
left a comment
There was a problem hiding this comment.
Fantastic, thanks @joshuay03 🙏🏼
I've tested this branch locally in our main test suite, seems good to me.
This was referenced Feb 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Addresses OOM issues by limiting concurrent uploads to 10 threads using
concurrent-ruby(previously unbounded) and ensuring traces are cleaned from memory after upload. The unbounded thread creation was the likely culprit for memory exhaustion.Also fixes a flaky test that was comparing exact gzipped bytes, which failed due to gzip timestamps. Now verifies decompressed content instead.