Conversation
nprizal
reviewed
May 28, 2025
tommeier
commented
May 29, 2025
| expect(failure_reason).to be_valid_encoding | ||
| end | ||
|
|
||
| it 'removes invalid UTF-8 characters from nested values' do |
|
Need to double check which versions of ruby we need to support with this, as cucumber 9 requires ruby 2.7 and above. |
added 2 commits
June 4, 2025 13:11
|
Have tested this locally and it is uploading executions to TE as it should. |
malclocke
approved these changes
Jun 4, 2025
Co-authored-by: Malcolm Locke <malcolm@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very rough, untested - to be tested next.