API endpoint configurable with BUILDKITE_ANALYTICS_ENDPOINT#239
Merged
API endpoint configurable with BUILDKITE_ANALYTICS_ENDPOINT#239
BUILDKITE_ANALYTICS_ENDPOINT#239Conversation
niceking
approved these changes
Feb 6, 2025
Contributor
|
Change looks fine, looks like a test needs to be updated tho |
dffe15a to
87ca2ff
Compare
Useful for testing.
87ca2ff to
146a6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the API endpoint configurable from the
BUILDKITE_ANALYTICS_ENDPOINTenvironment variable.It defaults to
https://analytics-api.buildkite.com/v1/uploads, was previously only configurable by Ruby code:But it can be useful to inject different endpoints without changing the code, for testing etc.