Conversation
yob
commented
Feb 4, 2025
.buildkite/steps/release-gem
Outdated
|
|
||
| # Skip while testing | ||
| # gem push "${GEM_FILENAME}" | ||
| echo "pretend push ${GEM_FILENAME}" |
Contributor
Author
There was a problem hiding this comment.
After this has been reviewed and before it merges, we should change this to plain gem push .... . I had it like this for testing
Contributor
Author
|
I'm not thrilled with the amount of bespoke bash I had to right for this. It'd be nice to ... not have it. Maybe later we can extract the pattern into a "rubygems-release" plugin that pairs well with the "rubygems-oidc" plugin or something.... |
yob
commented
Feb 4, 2025
|
|
||
| - command: ".buildkite/steps/release-gem" | ||
| label: ":rubygems:" | ||
| if: build.tag != null |
Contributor
Author
There was a problem hiding this comment.
This adds a new pipeline.yml specifically for pushing gem releases to rubygems.org. We use the `rubygems-oidc` plugin to swap a Buildkite OIDC token for a temporary rubygems.org token that has permission to push this gem - that exchange process will only work from a special Buildkite pipeline that is triggered by a tag push to the repository. I've updated the README with the new process. It's largely the same, except now any staff member with access to the release pipeline can approve the release. They no longer need to be added as an owner on the gem [1], or need to have access to any shared credentials for our rubygems.org user. [1] https://rubygems.org/gems/buildkite-test_collector
pda
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new pipeline.yml specifically for pushing gem releases to rubygems.org. We use the
rubygems-oidcplugin to swap a Buildkite OIDC token for a temporary rubygems.org token that has permission to push this gem - that exchange process will only work from a special Buildkite pipeline that is triggered by a tag push to the repository.I've updated the README with the new process. It's largely the same, except now any staff member with access to the release pipeline can approve the release. They no longer need to be added as an owner on the gem, or need to have access to any shared credentials for our rubygems.org user.