HTTPClient: #post_upload replaces #post_json; receives run_env#234
Merged
Conversation
#post_upload replaces #post_json; receives run_env
ccdda0d to
3b37e5e
Compare
gchan
approved these changes
Feb 3, 2025
bea7372 to
f285ee4
Compare
Rather than HTTPClient#post_json reaching out to `Buildkite::TestCollector::CI.env` (which is then dependent on environment variables etc and harder to test), we can pass that `run_env` into `#post_upload`. This paves the way for also passing in `tags` alongside `run_env`.
3b37e5e to
52d0a02
Compare
nprizal
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further to #233, refactor
HTTPClient#post_upload(previously called#post_json) to receiverun_envas a keyword argument, instead of reaching out toBuildkite::TestCollector::CI.env(which is then dependent on environment variables etc and harder to test).Buildkite::TestCollector::CI.envitself is tested separately, so we still have coverage across the generatedrun_env.I'm extracting this refactor from another change which will add tagging support, to make that other change smaller.
Related: