Relax go directive to permit 1.24.x#4
Closed
Hayden-IO wants to merge 1 commit into
Closed
Conversation
Setting this to 1.24.3 requires all consumers to be building with 1.24.3 or newer release of Go 1.24 and to update their own go.mod accordingly. This is unnecessarily restrictive - the go directive should be the minimum version necessary for the Go features used by the module, with consumers using the latest Go version when building. With this fix, we can also update the go directive in buildkite/agent to 1.24.0, and further update dependents of buildkite/agent (for my use case, this is sigstore/cosign).
Author
|
Whoops, this is a dup of #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting this to 1.24.3 requires all consumers to be building with 1.24.3 or newer release of Go 1.24 and to update their own go.mod accordingly. This is unnecessarily restrictive - the go directive should be the minimum version necessary for the Go features used by the module, with consumers using the latest Go version when building.
With this fix, we can also update the go directive in buildkite/agent to 1.24.0, and further update dependents of buildkite/agent (for my use case, this is sigstore/cosign).