feat: no longer set tokens in the config file#679
Merged
Conversation
## Description Text tokens are bad, so we shouldn't set them in the config file anymore ## Changes - removes the setters from the various commands where login/auth might be performed - allows for fallback to a config token where it's already set - warns that this shouldn't be done - updates tests to reflect changes - precedence: env var > keychain > config (read-only)
We don't want people to use it now
scadu
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Text tokens are bad, so we shouldn't set them in the config file anymore
Changes
Testing
go test ./...)go fmt ./...)