Skip to content

chore: remove graphql as a dependency for pipeline view#663

Merged
mcncl merged 1 commit intomainfrom
chore/pipeline_view_delete_graphql
Feb 25, 2026
Merged

chore: remove graphql as a dependency for pipeline view#663
mcncl merged 1 commit intomainfrom
chore/pipeline_view_delete_graphql

Conversation

@mcncl
Copy link
Contributor

@mcncl mcncl commented Feb 25, 2026

Description

Currently bk pipeline view outputs some "nice" things like emoji etc, but it's not going to work at all with OAuth due to it needing GraphQL as a permission.

Changes

  • changes the bk pipeline view command to return the REST API response (via go-buildkite)
  • removes the graphql query entirely (and the tests covering its output)

Testing

  • Tests have run locally (with go test ./...)
  • Code is formatted (with go fmt ./...)

Currently `bk pipeline view` outputs some "nice" things like emoji etc, but it's not going to work at all with OAuth due to it needing GraphQL as a permission.

- changes the `bk pipeline view` command to return the REST API response (via go-buildkite)
- removes the graphql query entirely (and the tests covering its output)
@mcncl mcncl requested a review from a team as a code owner February 25, 2026 00:00
return browser.OpenURL(fmt.Sprintf("https://buildkite.com/%s", slug))
}

resp, err := graphql.GetPipeline(ctx, f.GraphQLClient, slug)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using graphql will break this entire command when OAuth is GA, because created tokens won't automatically have GraphQL (unscoped) permissions

@mcncl mcncl merged commit 2aee830 into main Feb 25, 2026
1 check passed
@mcncl mcncl deleted the chore/pipeline_view_delete_graphql branch February 25, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants