Remove the requirement for setting --org, fixes browser bug#661
Merged
Conversation
- a user should be able to run `bk auth login` and be taken to the browser - when setting `--org` currently, there is a caching issue where the most recent auth'd org is selected - this means the user has to select the correct org, deeming `--org` useless anyway
PriyaSudip
reviewed
Feb 24, 2026
cmd/auth/login.go
Outdated
|
|
||
| orgSlug := orgs[0].Slug | ||
| if len(orgs) > 1 { | ||
| fmt.Println("Token is authorized for multiple organizations:") |
Contributor
There was a problem hiding this comment.
Since we are sticking to the first org, should we ask if they want to change or choose a different one?
Contributor
Author
There was a problem hiding this comment.
This was copy/pasted from some other logic and not cleaned up; we can't have a token with > 1 org, so we don't need that check
dad7486 to
56c89e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently there are a couple of minor bugs in the
auth loginflow;bk auth loginand be taken to the browser (currently--orgrequired)--orgcurrently, there is a caching issue where the most recent auth'd org is selected--orguseless anywayChanges
orgflag fromloginentirely;--orgis set tobk auth loginto be run, opening the browser and correctly associating with the manually selected orgTesting
go test ./...)go fmt ./...)