Skip to content

Add DAP capabilities to BSP#99

Merged
mzarnowski merged 1 commit intobuild-server-protocol:masterfrom
mzarnowski:dap
Sep 13, 2019
Merged

Add DAP capabilities to BSP#99
mzarnowski merged 1 commit intobuild-server-protocol:masterfrom
mzarnowski:dap

Conversation

@mzarnowski
Copy link
Copy Markdown
Contributor

This allows the client to run/debug code using the Debug Adapter Protocol

Copy link
Copy Markdown
Contributor

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only one comment. Would you mind looking at the reason why the CI is failing? Looks like Travis is unable to install the JDK 8 with the script we had before.

@jvican jvican added the enhancement New feature or request label Sep 11, 2019
@mickaelistria
Copy link
Copy Markdown

That integration can be extremely interesting.
Can you please describe some typical user-stories and interactions that could leverage the DAP support? Basically, what gets debugged? The build process or the resulting app?

@mzarnowski
Copy link
Copy Markdown
Contributor Author

mzarnowski commented Sep 12, 2019

Our intention here is to provide a working DAP implementation which can later be used from Metals. Our end goal here is to add the capability of launching main classes and test suites from LSP client (e.g. vscode) using code lenses (basically buttons above the main class or test suite like in IntelliJ, if you are not familiar with the term)

what gets debugged?

That depends on the DebugSessionParams.dataKind field. Currently we are planning a support for jvm main classes and various jvm test suites. For more technical information you can follow a (rather lenghty) thread in this bloop PR.

If you have more questions then, if the are related to the BSP let's continue the discussion here. Otherwise, don't hesitate to ask them in the linked bloop PR.

@mzarnowski
Copy link
Copy Markdown
Contributor Author

mzarnowski commented Sep 12, 2019

Would you mind looking at the reason why the CI is failing?

Fixed in #100, I will rebase the PRs after it is merged

@jvican
Copy link
Copy Markdown
Contributor

jvican commented Sep 12, 2019

@mickaelistria As Marek says, feel free to drop by the Bloop PR or our gitter channel https://gitter.im/scalacenter/bloop if you want to know more about the details, we're happy to elaborate on how we envision the DAP<>BSP integration.

@marek1840 Ready to merge, feel free to press the merge button when you rebase 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants