Add debug provider to build server capabilities#161
Add debug provider to build server capabilities#161jastice merged 6 commits intobuild-server-protocol:masterfrom
Conversation
olafurpg
left a comment
There was a problem hiding this comment.
Thank you for this contribution! This is a good improvement. The implementation looks good. Can you please update specification.md to match the implementation?
For better or worse, there's a lot of repetition in adding new BSP features 😅
|
@olafurpg thanks, I've attempted to add the correct information to |
|
I think we should already be able to use canRun/canDebug - I didn't realise we had that. And since we implement both that and debug I don't imagine it would be super useful in case of Metals. I do believe it's a worthwhile addition and might be useful in the future. |
FYI: |
Co-authored-by: Adrien Piquerez <adrien.piquerez@gmail.com>
|
I got a deserialization failure when trying against the scala code - java worked, UpdateI got this fixed and added an explicit test. I had to add in |
92720b0 to
f862ef3
Compare
This attempts to address #145
Specifically, looking to improve how metals can support debug support: https://github.com/adpi2/metals/pull/1/files#diff-2249f2a7f1d0baedcc556404e0eb12adcd38f5fdb4d0d640d662643bc3de5b1fR514
TODO:
BuildTargetCapabilitiesto verify backward compatability