Add YAML runner config support #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugy
requested changes
Aug 31, 2022
src/utils/custom_yaml.py
Outdated
Comment on lines
6
to
9
| contents='' | ||
| for line in content.split('\n'): | ||
| if not re.match (r'\s*//.*', line): | ||
| contents += line + "\n" |
Owner
There was a problem hiding this comment.
I believe this is not needed. Yaml supports comments by default (in the specification and in the library)
Owner
|
Hi @anthony-francisco thanks for PR! I left a couple of comments which would be cool to solve |
Contributor
Author
|
Hi @bugy , I made some changes (regarding your comments). |
Owner
|
Hi @anthony-francisco thanks :) Could you also check my comment in custom_yaml.py? |
Contributor
Author
|
Hi @bugy , I forget to add/push/commit the moved of the "import yaml" line inside the loads function. |
bugy
approved these changes
Sep 7, 2022
Owner
|
Great, thank you for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.