fix(discord): preserve streamed assistant preview when a tool failure follows#1
Open
bugkill3r wants to merge 1 commit into
Open
fix(discord): preserve streamed assistant preview when a tool failure follows#1bugkill3r wants to merge 1 commit into
bugkill3r wants to merge 1 commit into
Conversation
… follows When a turn produces both a streamed assistant text reply and a tool-failure warning, the warning would arrive as an isError final payload after the assistant preview was already rendered. The deliver path then called draftStream.clear() and the cleanup finally also deleted the preview, leaving only the warning visible. Detect this case synchronously after flushDraft and claim the 'finalized' state before any further awaits so neither the deliver path nor the cleanup finally deletes the preserved preview. The warning is still delivered as a separate follow-up reply. Closes openclaw#83831
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a turn produces both a streamed assistant text reply and a
tool-failure warning, the warning would arrive as an isError final
payload after the assistant preview was already rendered. The deliver
path then called draftStream.clear() and the cleanup finally also
deleted the preview, leaving only the warning visible.
Detect this case synchronously after flushDraft and claim the
'finalized' state before any further awaits so neither the deliver
path nor the cleanup finally deletes the preserved preview. The
warning is still delivered as a separate follow-up reply.
Closes openclaw#83831