fix(core): import build_provider_from_entry in mod tests so gonka_tests can resolve it#3634
Merged
fix(core): import build_provider_from_entry in mod tests so gonka_tests can resolve it#3634
Conversation
…ts can resolve it mod gonka_tests uses `use super::*` which resolves to mod tests. Since build_provider_from_entry was not imported into mod tests, the 4 gonka_tests failed to compile when --features gonka is enabled. Closes #3633
…"gonka\") Without the cfg gate, RUSTFLAGS=-D warnings treats the import as unused when the gonka feature is disabled, breaking the MSRV and build-tests CI jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_provider_from_entryto theuse super::import inmod testsinprovider_factory.rsmod gonka_testsusesuse super::*, which resolves tomod tests; sincebuild_provider_from_entrywas not imported there, all 4 gonka tests failed to compile under--features gonkaTest plan
cargo nextest run --workspace --features gonka --lib -p zeph-core— all 4gonka_tests::*tests passcargo +nightly fmt --check— no diffcargo clippy --workspace --features gonka -- -D warnings— zero errorsCloses #3633