fix(lsp): handle mcpls object-wrapped diagnostics response#3594
Merged
fix(lsp): handle mcpls object-wrapped diagnostics response#3594
Conversation
mcpls v0.3.6 changed get_diagnostics to return {"diagnostics": [...]}
instead of a bare array. The old parser expected a bare array and
silently returned None on every call, preventing LSP diagnostics from
ever being injected into the prompt.
Replace the direct Vec<_> deserialization with a parse_diagnostics_json
helper that accepts both the legacy bare-array format and the
object-wrapper format by extracting .get("diagnostics") when present.
Adds regression test and 4 edge-case unit tests (bare array, empty
wrapper, missing key, invalid JSON). All 9184 tests pass.
Closes #3593
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_diagnosticsinzeph-core/src/lsp_hooks/diagnostics.rssilently returnedNoneon every call because it expected a bare JSON array from mcplsget_diagnostics, but mcpls v0.3.6+ returns{"diagnostics": [...]}(aDiagnosticsResultstruct)parse_diagnostics_json()helper that handles both the legacy bare-array format and the object-wrapper formatTest plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleancargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 9184/9184 passedCloses #3593