fix(skills): consolidate EmbedUnsupported warnings into single summary#1703
Merged
fix(skills): consolidate EmbedUnsupported warnings into single summary#1703
Conversation
When a provider does not support embeddings (e.g. claude), SkillMatcher::new() previously emitted one WARN per skill, producing 14 identical log entries on startup. All EmbedUnsupported errors are now collected and emitted as a single summary warning: "skill embeddings skipped: embedding not supported by <provider> (N skills affected)". Timeout and other per-skill errors continue to be logged individually. Adds two tests covering the all-unsupported and partial-unsupported cases. Closes #1387
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillMatcher::new()no longer emits oneWARNper skill when the provider does not support embeddingsEmbedUnsupportederrors are collected and summarised into a single warning:skill embeddings skipped: embedding not supported by claude (14 skills affected)test_matcher_new_returns_none_when_all_unsupportedandtest_matcher_new_partial_unsupported_falls_back_to_supportedCloses #1387
Test plan
cargo clippy --workspace --features full -- -D warningspassescargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5303 tests pass