feat(orchestration): count tasks completed before cancellation in metrics#1690
Merged
feat(orchestration): count tasks completed before cancellation in metrics#1690
Conversation
…rics In finalize_plan_execution(), the GraphStatus::Canceled arm already computed done_count but never passed it to update_metrics(). This caused tasks_completed to be under-reported when a plan was canceled mid-execution. Mirrors the Completed arm: calls update_metrics(|m| m.orchestration.tasks_completed += done_count as u64) immediately after computing done_count. Updated COV-02 test to assert the metric is incremented via a watch channel receiver. Closes #1612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finalize_plan_execution(), theGraphStatus::Canceledarm computeddone_countbut never calledupdate_metrics(), leavingtasks_completedunder-reported when a plan was canceled mid-execution.self.update_metrics(|m| m.orchestration.tasks_completed += done_count as u64)in theCanceledarm, mirroring theCompletedarm.watch::channelreceiver.Test plan
cargo nextest run -p zeph-core -E 'test(finalize_plan_execution_canceled)'passescargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5298 passed, 0 failedCloses #1612