fix(memory): wire semantic ranking options from config into SemanticMemory#1678
Merged
fix(memory): wire semantic ranking options from config into SemanticMemory#1678
Conversation
…emory build_memory() constructed SemanticMemory without calling with_ranking_options(), causing temporal_decay_enabled, temporal_decay_half_life_days, mmr_enabled, and mmr_lambda from [memory.semantic] to be silently ignored. Both features always ran with hardcoded defaults (disabled) regardless of user configuration. Closes #1668
bd7c079 to
2487fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_memory()inzeph-corenever called.with_ranking_options()after constructingSemanticMemorytemporal_decay_enabled,temporal_decay_half_life_days,mmr_enabled,mmr_lambda) were parsed from[memory.semantic]but silently ignoredFix
Added a single
.with_ranking_options()call after thematchblock inbuild_memory(), covering both the SQLite and Qdrant construction paths.Test plan
cargo +nightly fmt --check— passcargo clippy --workspace --features full -- -D warnings— pass (0 warnings)cargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5267 passed, 0 failedFixes #1668