fix(acp): forward /scheduler, /graph, /plan slash commands to agent loop#1675
Merged
fix(acp): forward /scheduler, /graph, /plan slash commands to agent loop#1675
Conversation
In handle_prompt(), replace the denylist exclusion with slash_command_pass_through() that explicitly lists commands to forward to zeph-core. Fixes /scheduler list (and all subcommands) returning "unknown command" in ACP sessions (Zed, Helix, VS Code). Adds /graph and /plan to the pass-through list as they were broken for the same reason. Adds unit tests for slash_command_pass_through(). Follow-up: #1672 tracks remaining broken agent-loop commands. Closes #1658
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_prompt()withslash_command_pass_through()— a named helper that explicitly lists which slash commands must be forwarded to the core agent loop/scheduler list(and all subcommands) no longer returns"unknown command"in ACP sessions (Zed, Helix, VS Code)/graphand/planwhich were broken for the same reasonslash_command_pass_through()Root cause
handle_prompt()inzeph-acpintercepted all/inputs and routed them to ACP's ownhandle_slash_command()— unless they were exactly/compactor/model refresh. When PR #1648 added/scheduler listto the core agent loop, the ACP pass-through was not updated.Changes
crates/zeph-acp/src/agent/mod.rs: extractedslash_command_pass_through(), updatedhandle_prompt()conditioncrates/zeph-acp/src/agent/tests.rs: added unit tests for the helperTest plan
cargo +nightly fmt --check— passescargo clippy --workspace --features full -- -D warnings— passescargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5266/5266 passedFollow-up
#1672 tracks the remaining broken agent-loop commands (
/status,/skills,/mcp,/image,/log,/agent, etc.) which hit the same issue.Closes #1658