feat(gemini): omit parameters field for no-parameter tools#1674
Merged
feat(gemini): omit parameters field for no-parameter tools#1674
Conversation
When a tool has no parameters, convert_tool_definitions() previously
produced parameters: {type: OBJECT, properties: {}}. The Gemini API
accepts this but the spec allows omitting the field entirely.
Change GeminiFunctionDeclaration.parameters to Option<serde_json::Value>
with skip_serializing_if = "Option::is_none". Add is_empty_object_schema()
helper that detects empty-object schemas (absent or empty properties key).
Update convert_tool_definitions to return None for no-param tools.
Closes #1641. Part of #1592.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeminiFunctionDeclaration.parameterstoOption<serde_json::Value>with#[serde(skip_serializing_if = "Option::is_none")]is_empty_object_schema()helper detecting empty-object schemas (empty or absentproperties)convert_tool_definitionsto returnNonefor no-parameter tools instead of{type: OBJECT, properties: {}}test_convert_tool_no_parameters,test_is_empty_object_schemaCloses #1641. Part of #1592.
Test plan
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspassescargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --binspasses (5264 tests, +4 new)test_convert_tool_no_parametersverifiesparameterskey absent in serialized JSONtest_is_empty_object_schemacovers all 4 branches including missingpropertieskey