fix(acp): apply document RAG and graph memory config to ACP sessions#1653
Merged
fix(acp): apply document RAG and graph memory config to ACP sessions#1653
Conversation
ACP sessions were silently using DocumentConfig::default() (rag_enabled=false) and GraphConfig::default() (enabled=false) regardless of TOML settings because spawn_acp_agent never called with_document_config() or with_graph_config(). Add document_config and graph_config fields to SharedAgentDeps, populate them in build_acp_deps from config.memory, and forward them in spawn_acp_agent following the same pattern as runner.rs:826-827. Fixes #1634, fixes #1633.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document_configandgraph_configfields toSharedAgentDepsinsrc/acp.rsbuild_acp_depsfromconfig.memory.documentsandconfig.memory.graphwith_document_config()/with_graph_config()inspawn_acp_agent, matching the pattern inrunner.rs:826-827SharedAgentDepsFixes #1634 (document RAG config silently disabled for ACP sessions)
Fixes #1633 (graph memory config silently disabled for ACP sessions)
Root cause
DocumentConfig::default()hasrag_enabled = falseandGraphConfig::default()hasenabled = false. Without forwarding user config, all ACP sessions ignored the TOML settings.Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleancargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5228 passed, 0 failedshared_agent_deps_has_document_and_graph_config_fields