fix(security): truncate secret_key in confirmation prompt#1499
Merged
Conversation
Cap secret_key at 100 chars in all three confirmation prompt sites using the existing truncate_to_chars helper. Reject keys longer than 100 chars at the sub-agent input-validation layer in manager.rs. Add unit tests for the new truncation boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1480.
Changes
crates/zeph-core/src/agent/mod.rs: applytruncate_to_chars(&req.secret_key, 100)at all 3 confirmation prompt sites inprocess_pending_secret_requests()crates/zeph-core/src/subagent/manager.rs: reject keys longer than 100 chars at the validation layer (ASCII charset check)secret_key_over_100_chars_truncated,secret_key_exactly_100_chars_unchangedConsistent with the
reasonfield fix in #1456 (200-char cap viatruncate_to_chars).Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleancargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 4942 passed