fix(orchestration): use main agent inline when no sub-agents configured (#1463)#1489
Merged
fix(orchestration): use main agent inline when no sub-agents configured (#1463)#1489
Conversation
…ed (#1463) When available_agents is empty, RuleBasedRouter returns None and the scheduler now emits SchedulerAction::RunInline instead of marking tasks failed. The agent loop handles RunInline by calling the main provider directly, recording a synthetic spawn, and sending the result via the event channel. Also fix /plan status always showing "awaiting confirmation" regardless of actual graph state. handle_plan_status now matches on GraphStatus and returns the appropriate message for each variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchedulerAction::RunInlinevariant: whenAgentRouter::route()returnsNone(no sub-agents configured), the scheduler emitsRunInlineinstead of immediately marking the taskFailed. The agent loop handles it by calling the main provider directly, recording a synthetic spawn, and sending the result via the event channel. Closes Orchestration: AgentRouter fails when no sub-agents configured #1463/plan statusalways showing "awaiting confirmation" regardless of actual graph state — now matches onGraphStatusand returns the correct message per varianttest_no_agent_routes_inline(wastest_no_agent_marks_task_failed) to reflect new behaviorplan_confirm_no_subagents_executes_inline,plan_status_reflects_graph_status,plan_confirm_inline_provider_failure_sends_messageTest plan
cargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 4928/4928 passcargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— clean/plan goal "Write hello world"+/plan confirmwith no sub-agents configured → plan executes inline/plan confirm→ fail task →/plan status→ shows "Plan failed. Use/plan retry..."