fix(deps-bundler): handle wildcard in version_matches_requirement#92
Merged
fix(deps-bundler): handle wildcard in version_matches_requirement#92
Conversation
5d763b1 to
f66a282
Compare
version_matches_requirement did not handle the "*" wildcard requirement, causing get_latest_matching to always return None. This left cached_versions empty and made inlay hints produce zero results for all Gemfile dependencies. Fixes #89
f66a282 to
fd918cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version_matches_requirementincrates/deps-bundler/src/version.rsdid not handle the"*"wildcard requirementget_latest_matching(name, "*")for each Gemfile dependency; without wildcard support it always returnedNonecached_versionsempty, causinggenerate_inlay_hintsto produce zero resultsFix
Added a wildcard guard at the top of
version_matches_requirement:Added three test cases covering wildcard behavior.
Test plan
cargo +nightly fmt --all -- --checkpassedcargo clippy --workspace --all-targets --all-features -- -D warningspassedcargo nextest run --workspace --all-features --no-fail-fast— 1314 passed, 37 skippedCloses #89