Conversation
… corruption complete_features() was passing Range::default() (position 0,0-0,0) as insert_range to build_feature_completion, producing a textEdit that, per LSP spec, takes precedence over insertText and inserts the feature name at the beginning of the file instead of the cursor position. Change build_feature_completion to accept Option<Range> and omit textEdit entirely when None is passed, matching the behaviour of complete_versions_generic. Pass None from complete_features. Closes #88
6bb8891 to
7dd2802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
complete_features()was passingRange::default()(position(0,0)-(0,0)) tobuild_feature_completion, generating atextEditwith an empty range at the document starttextEdittakes precedence overinsertText, so strict clients inserted the feature name at the beginning of the file instead of the cursor — corrupting the manifestbuild_feature_completionto acceptOption<Range>and omittextEditwhenNone, matching the existing pattern incomplete_versions_genericTest plan
cargo nextest run -p deps-core -E 'test(feature_completion)'— newtest_build_feature_completionassertstext_edit.is_none()whenNonerange is passed;test_build_feature_completion_with_rangecovers theSome(range)pathcargo nextest run --workspace --all-features --lib --binsCargo.tomlwithserde = { version = "1", features = ["de"] }, place cursor inside"de", trigger completion, apply a feature — text appears at cursor, not at line 0Closes #88