fix(cargo,bundler): remove quotes from format_version_for_text_edit#87
Merged
fix(cargo,bundler): remove quotes from format_version_for_text_edit#87
Conversation
The TextEdit range produced by toml_span (Cargo) and the Bundler parser covers only the version value content, excluding surrounding delimiters. format_version_for_text_edit was wrapping the version in quotes, causing doubled delimiters when the editor applied the edit. Return the bare version string; the existing delimiters in the document are preserved by the range. Closes #85
c856b33 to
592073e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CargoFormatter::format_version_for_text_editreturned"1.0.0"(with double quotes); TextEdit range excludes delimiters, causing""1.0.0""after applyBundlerFormatter::format_version_for_text_editreturned'1.0.0'(with single quotes); same issue, producing''1.0.0''Test plan
cargo nextest run -p deps-cargo -p deps-bundler— formatter tests updated and passingcargo nextest run --workspace --all-features --no-fail-fast— 1304 tests passedserde = "1.0.0"in Cargo.toml → result isserde = "1.0.228"(no doubled quotes)gem 'rails', '7.0.0'in Gemfile → result is valid Ruby (no doubled single quotes)Closes #85