Conversation
… async_trait Remove ~2000 lines of deprecated handler.rs and legacy trait system (PackageRegistry, VersionInfo, PackageMetadata, EcosystemHandler). Add default method implementations to Ecosystem trait for generate_inlay_hints, generate_hover, generate_code_actions, generate_diagnostics — eliminating ~400 lines of identical boilerplate across 8 ecosystem crates. Replace async_trait proc-macro with explicit BoxFuture pattern across Ecosystem, Registry, and LockFileProvider traits and all implementations. Centralize test mock types (MockDep, MockParseResult) in deps-core. Closes #68
faaf345 to
a02f113
Compare
Closed
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handler.rsand legacy trait system (PackageRegistry,VersionInfo,PackageMetadata,EcosystemHandler)Ecosystemtrait for LSP handlers, eliminating ~400 lines of identical boilerplate across 8 ecosystem cratesasync_traitproc-macro with explicitBoxFuturepattern across all async traits (14% build time improvement)MockDep,MockParseResult) indeps-coreNet result: -3500 lines, 14% faster builds, zero test regressions (1088 tests + 16 doc tests pass)
Test plan
cargo +nightly fmt --checkcargo clippy --workspace --all-targets --all-features -- -D warningscargo nextest run --workspace --lib --bins(1088 passed)cargo test --workspace --doc --all-features(16 passed)