fix(cargo): handle multi-byte chars in name range search#58
Merged
Conversation
Adjust search_start to char boundary when slicing content for dependency name lookup, preventing panic on Cargo.toml files containing multi-byte UTF-8 characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saturating_subon byte offset could land inside a multi-byte char, causing slice panicsearch_startto nearest char boundary before slicingReproduced with AppFlowy's
frontend/rust-lib/Cargo.tomlwhich contains⚠in comments.Test plan
cargo nextest run -p deps-cargo— 91 passedcargo clippy— clean