Add support for BCR publishing#99
Merged
2 commits merged intomainfrom Jun 6, 2025
Merged
Conversation
Author
|
(I can add other people to the maintainer list. I am adding myself though because bcr-bot will actually be the creator of the PRs in this setup, so I'm paranoid that having one maintainer might result in a deadlock in some cases.) |
smaye81
approved these changes
Jun 6, 2025
| module(name = "protovalidate-cc") | ||
| module( | ||
| name = "protovalidate-cc", | ||
| version = "0.0.0", |
Contributor
There was a problem hiding this comment.
Should this version be the actual version of protovalidate-cc? Not sure if this is intended.
Author
There was a problem hiding this comment.
This is intended, the release_prep phase will set the version.
| remote = "https://github.com/bufbuild/protovalidate-cc.git", | ||
| commit = "<commit hash>" | ||
| ) | ||
| bazel_dep(name = "protovalidate-cc", version = "1.0.0-rc2") |
Author
There was a problem hiding this comment.
rc1 can never be in the BCR because it has a dependency that can't be satisfied. So the soonest possible BCR release is whatever comes after that
Author
There was a problem hiding this comment.
It should, however, have been rc.2. My bad :)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately we will probably need a couple of tries to get this right, but hopefully this is very close to what we want.
Closes #98.