Use tagged BCR release workflow#117
Merged
2 commits merged intomainfrom Jul 17, 2025
Merged
Conversation
While waiting for the changes that allow the BCR release workflow to create a draft release instead of publishing the release immediately, I was using a branch reference to try to get SLSA to work. Unfortunately that doesn't work: the SLSA attestation won't be trusted unless we're using a tagged version of the workflow. At some point, a tag was created for the merged change, so we can move to it now. With any luck, this should allow the next release of protovalidate-cc to pass attestation.
srikrsna-buf
approved these changes
Jul 17, 2025
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While waiting for the changes that allow the BCR release workflow to create a draft release instead of publishing the release immediately, I was using a branch reference to try to get SLSA to work. Unfortunately that doesn't work: the SLSA attestation won't be trusted unless we're using a tagged version of the workflow. At some point, a tag was created for the merged change, so we can move to it now. With any luck, this should allow the next release of protovalidate-cc to pass attestation.