Skip to content

Update count for new protobuf version#115

Merged
1 commit merged intobufbuild:mainfrom
FoxMoss:main
Jul 17, 2025
Merged

Update count for new protobuf version#115
1 commit merged intobufbuild:mainfrom
FoxMoss:main

Conversation

@FoxMoss
Copy link
Copy Markdown
Contributor

@FoxMoss FoxMoss commented Jul 15, 2025

Without this patch the following error occurs when compiling the CMake example:

/home/foxmoss/Projects/protovalidate-cc/buf/validate/internal/message_rules.cc: In function ‘buf::validate::internal::Rules buf::validate::internal::NewMessageRules(std::unique_ptr<MessageFactory>&, bool, google::protobuf::Arena*, google::api::expr::runtime::CelExpressionBuilder&, const google::protobuf::Descriptor*)’:
/home/foxmoss/Projects/protovalidate-cc/buf/validate/internal/message_rules.cc:84:59: error: no matching function for call to ‘std::unordered_set<std::__cxx11::basic_string<char> >::count(absl::lts_20250512::string_view)’
   84 |     if (!fieldLvl.get().has_ignore() && allMsgOneofs.count(field->name()) > 0) {
      |                                         ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~

Unsure how to update the version in shared_deps.json as bumping "version" to 31.2 results in errors.

@ghost
Copy link
Copy Markdown

ghost commented Jul 17, 2025

I'm not too concerned about actually updating the protobuf version in step with this, since this change should work with the old versions just fine. Thanks. I think I'll go ahead and merge this even though it is still in draft.

@ghost ghost marked this pull request as ready for review July 17, 2025 15:41
@ghost ghost merged commit feacae8 into bufbuild:main Jul 17, 2025
8 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant