Fix Bazel WORKSPACE instructions in readme and release message#111
Merged
3 commits merged intobufbuild:mainfrom Jun 23, 2025
Merged
Fix Bazel WORKSPACE instructions in readme and release message#1113 commits merged intobufbuild:mainfrom
3 commits merged intobufbuild:mainfrom
Conversation
For example, https://github.com/bufbuild/protovalidate-cc/releases/tag/v1.0.0-rc.5 links to https://github.com/bufbuild/protovalidate-cc/releases/download/v1.0.0-rc.5/protovalidate-cc-v1.0.0-rc.5.tar.gz which 404s, but https://github.com/bufbuild/protovalidate-cc/releases/download/v1.0.0-rc.5/protovalidate-cc-1.0.0-rc.5.tar.gz and https://github.com/bufbuild/protovalidate-cc/archive/v1.0.0-rc.5.tar.gz are valid links.
ghost
approved these changes
Jun 23, 2025
This is just to match the existing syntax in the README; the `{version}` placeholder is meant to be the semver version number, e.g. without the `v` prefix. This should be correct for using the release artifact archives...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example,
https://github.com/bufbuild/protovalidate-cc/releases/tag/v1.0.0-rc.5 links to https://github.com/bufbuild/protovalidate-cc/releases/download/v1.0.0-rc.5/protovalidate-cc-v1.0.0-rc.5.tar.gz which 404s, but
https://github.com/bufbuild/protovalidate-cc/releases/download/v1.0.0-rc.5/protovalidate-cc-1.0.0-rc.5.tar.gz and
https://github.com/bufbuild/protovalidate-cc/archive/v1.0.0-rc.5.tar.gz are valid links.